Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dep] Add ack-grep. #19272

Merged
merged 1 commit into from Oct 16, 2018
Merged

[dep] Add ack-grep. #19272

merged 1 commit into from Oct 16, 2018

Conversation

@mjcarroll mjcarroll merged commit 121ef62 into ros:master Oct 16, 2018
@130s 130s deleted the dep_ackgrep branch October 16, 2018 14:17
130s added a commit to 130s/rosdistro that referenced this pull request Mar 30, 2021
-    Arch https://www.archlinux.org/packages/community/any/ack/
-    Debian https://packages.debian.org/search?keywords=ack
-    Fedora http://rpmfind.net/linux/rpm2html/search.php?query=ack
-    Gentoo https://packages.gentoo.org/packages/sys-apps/ack
-    Ubuntu https://packages.ubuntu.com/search?keywords=ack

Problem: There's already `ack-grep` added in ros#19272, where the key points to `ack` for some distros. With that, the state of this commit/PR opens up the follwing questions/concerns:
- Removing `ack-grep` rosdep key would break some downstream usecases.
- For some distros, rosdep key `ack-grep` references to `ack`, but rosdep key `ack` does not.
@130s 130s mentioned this pull request Mar 30, 2021
wjwwood pushed a commit that referenced this pull request Mar 31, 2021
-    Arch https://www.archlinux.org/packages/community/any/ack/
-    Debian https://packages.debian.org/search?keywords=ack
-    Fedora http://rpmfind.net/linux/rpm2html/search.php?query=ack
-    Gentoo https://packages.gentoo.org/packages/sys-apps/ack
-    Ubuntu https://packages.ubuntu.com/search?keywords=ack

Problem: There's already `ack-grep` added in #19272, where the key points to `ack` for some distros. With that, the state of this commit/PR opens up the follwing questions/concerns:
- Removing `ack-grep` rosdep key would break some downstream usecases.
- For some distros, rosdep key `ack-grep` references to `ack`, but rosdep key `ack` does not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants