Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ros_control_boilerplate: 0.5.1-1 in 'melodic/distribution.yaml' [bloom] #28389

Merged
merged 1 commit into from Feb 25, 2021

Conversation

JafarAbdi
Copy link
Contributor

Increasing version of package(s) in repository ros_control_boilerplate to 0.5.1-1:

ros_control_boilerplate

* Replaced boost with std shared_ptr
* Make NodeHandle a const reference
* test_trajectory:  Read joints list from trajectory controller params
* Generalize GenericHWControlLoop to all types of RobotHW (#38 <https://github.com/PickNikRobotics/ros_control_boilerplate/issues/38>)
* Increase num AsyncSpinners where control loops are instantiated
* Contributors: AndyZe, Dave Coleman, Jafar Abdi, John Morris, Ramon Wijnands, Robert Wilbrandt, RobertWilbrandt, Tim Übelhör

@clalancette
Copy link
Contributor

Holding for the upcoming Melodic sync

@audrow audrow merged commit ed22974 into ros:master Feb 25, 2021
@clalancette
Copy link
Contributor

@JafarAbdi It looks like this change caused a regression in a downstream package: https://build.ros.org/view/Mbin_uB64/job/Mbin_uB64__moveit_sim_controller__ubuntu_bionic_amd64__binary/79/console . In particular, it looks like moveit_sim_controller was not prepared for the removal of the boost::shared_ptr APIs. Can you work with @davetcoleman to resolve it?

@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/preparing-for-melodic-sync-2021-03-15/19458/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants