REVIEWER_GUIDELINES combine bullets 2 and 3 #30920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
clalancette
reviewed
Oct 5, 2021
Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
clalancette
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation tweak.
Because REP 144 applies to both binary and source/doc packages, but it's only listed in the former.
Combining the binary and source/doc bullets to reduce confusion.
Please read revised entry to make sure it's still clear that a PR of any combo of bin/src/doc is valid.
I didn't change the wording, so none of that meaning should have changed. I only removed the bulleted list in the src/doc section and said to look at the binary section.