Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rviz_2d_overlay_plugins: 1.2.0-2 in 'rolling/distribution.yaml' [bloom] #34675

Merged
merged 2 commits into from Sep 27, 2022
Merged

rviz_2d_overlay_plugins: 1.2.0-2 in 'rolling/distribution.yaml' [bloom] #34675

merged 2 commits into from Sep 27, 2022

Conversation

ottojo
Copy link
Contributor

@ottojo ottojo commented Sep 27, 2022

Increasing version of package(s) in repository rviz_2d_overlay_plugins to 1.2.0-2:

rviz_2d_overlay_msgs

* Rename package from overlay_rviz_msgs to rviz_2d_overlay_msgs
* Contributors: Jonas Otto

rviz_2d_overlay_plugins

* Add missing dependencies to package.xml
* Fix various compiler-warnings (NFC)
* Rename package from overlay_rviz_plugins to rviz_2d_overlay_plugins
* Contributors: Jonas Otto

@github-actions github-actions bot added the rolling Issue/PR is for the ROS 2 Rolling distribution label Sep 27, 2022
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question; do you also want to add a doc stanza to your package? It isn't required, but if you add it the buildfarm will attempt to build doxygen docs for your package.

@ottojo
Copy link
Contributor Author

ottojo commented Sep 27, 2022

Quick question; do you also want to add a doc stanza to your package? It isn't required, but if you add it the buildfarm will attempt to build doxygen docs for your package.

Sounds good, will do. I dont think we currently have (useful) doxygen, but we can surely use this in the future for documentation. Under which URL will the docs be available?

I would also apreciate input on the question posted in the corresponding PR for humble: #34676 (comment)

@clalancette
Copy link
Contributor

Under which URL will the docs be available?

They'll show up on https://docs.ros.org/en/rolling/p/rviz_2d_overlay_plugins

@ottojo ottojo requested review from clalancette and removed request for nuclearsandwich September 27, 2022 13:10
@wjwwood wjwwood merged commit f3f4d21 into ros:master Sep 27, 2022
@ottojo ottojo deleted the bloom-rviz_2d_overlay_plugins-0 branch September 27, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rolling Issue/PR is for the ROS 2 Rolling distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants