Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rviz_2d_overlay_plugins: 1.2.0-2 in 'humble/distribution.yaml' [bloom] #34676

Closed
wants to merge 2 commits into from
Closed

rviz_2d_overlay_plugins: 1.2.0-2 in 'humble/distribution.yaml' [bloom] #34676

wants to merge 2 commits into from

Conversation

ottojo
Copy link
Contributor

@ottojo ottojo commented Sep 27, 2022

Increasing version of package(s) in repository rviz_2d_overlay_plugins to 1.2.0-2:

rviz_2d_overlay_msgs

* Rename package from overlay_rviz_msgs to rviz_2d_overlay_msgs
* Contributors: Jonas Otto

rviz_2d_overlay_plugins

* Add missing dependencies to package.xml
* Fix various compiler-warnings (NFC)
* Rename package from overlay_rviz_plugins to rviz_2d_overlay_plugins
* Contributors: Jonas Otto

@github-actions github-actions bot added the humble Issue/PR is for the ROS 2 Humble distribution label Sep 27, 2022
@ottojo
Copy link
Contributor Author

ottojo commented Sep 27, 2022

Question: I followed the release process for rolling so far (#34675), but we currently use/develop this package on humble.

I did check that the package builds on rolling, but i don't really want to maintain two separate branches for rolling and humble (or whatever the latest ros2 release is in the future).

Do you suggest not going forward with the rolling release in that case, even if the same branch (currently, by accident i suppose) works for both ros2 releases currently?

edit: Is is required/best practice to release on rolling anyways, as a "staging" environment to catch potential issues with future releases i guess?

@clalancette
Copy link
Contributor

edit: Is is required/best practice to release on rolling anyways, as a "staging" environment to catch potential issues with future releases i guess?

It is not required to release into Rolling, but we do consider it to be best practice. For exactly the reason you state; to catch potential issues early. If it is in Rolling, it will also be automatically released into the next ROS 2 distribution.

I did check that the package builds on rolling, but i don't really want to maintain two separate branches for rolling and humble (or whatever the latest ros2 release is in the future).

How you deal with your branching is completely up to you. The core ROS 2 packages have a separate branch for each ROS distribution; that allows us to evolve them independently. Some packages in here use a single branch for all ROS 2 distributions. Some packages in here use a single branch for all ROS 1 and ROS 2 distributions (though that takes more work).

In your case, my suggestion would be to keep using the same branch for both Humble and Rolling (with releases in both) as long as you can. If a breaking change comes to Rolling, then you can consider splitting off into a separate branch for that.

@ottojo
Copy link
Contributor Author

ottojo commented Sep 27, 2022

Thank you very much! In that case i will leave the PR as is (using main for both rolling and humble)! I will also add the doc section in here, as in the other PR.

@wjwwood
Copy link
Member

wjwwood commented Sep 27, 2022

Holding for Humble sync

@wjwwood wjwwood added the held for sync Issue/PR has been held because the distribution is in a sync hold label Sep 27, 2022
@ottojo
Copy link
Contributor Author

ottojo commented Sep 30, 2022

New version released in the meantime, closing in favor of #34714

@ottojo ottojo closed this Sep 30, 2022
@ottojo ottojo deleted the bloom-rviz_2d_overlay_plugins-1 branch September 30, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
held for sync Issue/PR has been held because the distribution is in a sync hold humble Issue/PR is for the ROS 2 Humble distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants