Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require specific versions of tinyxml2 #79

Closed
hashworks opened this issue Aug 22, 2017 · 5 comments · Fixed by #82
Closed

Require specific versions of tinyxml2 #79

hashworks opened this issue Aug 22, 2017 · 5 comments · Fixed by #82

Comments

@hashworks
Copy link
Contributor

I just had a problem with rospack and tinyxml2 Version 4, XML parsing failed on the <?xml-model ... lines.

Would it be possible to require specific versions of tinyxml2? Installing version 5 fixed the issue for me.
@dirk-thomas
Copy link
Member

Please see #77 which covers this issue. Since only version 4.0.0 and 4.0.1 have the bug we can't simply rely on version 5. E.g. version 2.x as well as 3.x are working fine too.

Which platform are you using which still has an unpatched version 4?

@hashworks
Copy link
Contributor Author

hashworks commented Aug 22, 2017 •
edited
Loading

The Debian stretch repositories offer v4.0.1.
Maybe a section in the README covering this would be good?

@dirk-thomas
Copy link
Member

Maybe a section in the README covering this would be good?

That would be great. Can you please create a PR for this suggestion adding a README.md file.

@dirk-thomas
Copy link
Member

@hashworks Can you please either follow up with a PR to the README if this is still a problem or close the ticket. Thanks.

@hashworks hashworks mentioned this issue Sep 26, 2017
Merged
@hashworks
Copy link
Contributor Author

Sorry for the delay, kinda forgot it.

dirk-thomas pushed a commit that referenced this issue Sep 26, 2017
@hashworks @dirk-thomas
Add README.md (#82)
7c60b5f 
* Add README.me

Mainly to add notes about tinyxml2 versions, resolves #79.

* Add information about patched tinyxml2 version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add README.md
2 participants
@dirk-thomas @hashworks