Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support name attribute for collisions #67

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

nlamprian
Copy link
Contributor

I added the name attribute in Collision, which interestingly enough, was only present in Visual.

@jspricke
Copy link
Member

jspricke commented Apr 7, 2021

@clalancette could we get this merged? Thanks!

@nlamprian
Copy link
Contributor Author

Is someone maintaining the package? If so, please review the PR. As it is, specifying a name in a collision tag appears as an error that confuses.

@sloretz
Copy link
Contributor

sloretz commented May 6, 2021

Context:

Since the C++ API supports this, it seems like a good idea to me to add it to the Python API

Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't try this locally, but the change and new test looks the same as how the name attribute is handled and tested for <visual> tags.

@sloretz sloretz requested a review from clalancette May 6, 2021 19:59
@brinij
Copy link

brinij commented Jul 21, 2021

@clalancette Could you please review this PR so it can be merged soon? That would be really helpful! Thanks!

@clalancette clalancette merged commit 66fcee5 into ros:melodic-devel Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants