Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urdfdom usage of std::stod is error-prone to changes in system locale #98

Closed
traversaro opened this issue May 5, 2017 · 4 comments
Closed
Labels

Comments

@traversaro
Copy link
Contributor

The use in several parts of urdfdom of the function std::stod can be source of errors if the library is used together with other libraries (such as Qt) that change the system locale.

Slightly related, I assume (from all the ROS code using the library) the correct way of encoding floating point numbers as strings in the URDF file format is the one defined by the "C" standard locale, but this is not actually documented anywhere (see robotology/idyntree#288 (comment)).

Downstream issue: robotology/idyntree#288
Similar SDFormat issue: https://bitbucket.org/osrf/sdformat/issues/60

@traversaro
Copy link
Contributor Author

cc @liesrock this is the issue I was mentioning today that is also affecting RBDL indirectly.

@liesrock
Copy link

liesrock commented May 9, 2017

thanks @traversaro, I cc @alaurenzi that can be also interested.

@traversaro
Copy link
Contributor Author

Fixed by #105 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants