Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xacro doesn't properly parse ROS substitution_args #3

Closed
smits opened this issue Mar 28, 2013 · 4 comments
Closed

xacro doesn't properly parse ROS substitution_args #3

smits opened this issue Mar 28, 2013 · 4 comments

Comments

@smits
Copy link

smits commented Mar 28, 2013

See ticket on code.ros.org: https://code.ros.org/trac/ros-pkg/ticket/5420

@piyushk
Copy link
Contributor

piyushk commented May 15, 2013

Just tested groovy_devel, and the patch seems to be working well.

@jonbinney
Copy link

Here's where this stands now:

  • substitution args patch has been merged into hydro-devel and released into hydro
  • its been merged into groovy-devel, but the groovy-devel version on github is catkinized, and there's too much risk that the catkinization will break come use cases, so we can't release again. Some work needs to be done to roll back the groovy-devel version here to rosbuild, and then re-apply the patch. Not sure I have time to do this right now, but if somebody does, I'll release it.
  • there is a separate issue for this in fuerte: Backport xacro substitution args fix to fuerte? #5

@jonbinney
Copy link

Went ahead and rolled the groovy-devel branch back to the last rosbuild version, and then backported the substitution args fix. The tests pass and script seems to work, but I'd like to get a couple other people to try it out and make sure I haven't broken anything before I do a release.

@wjwwood
Copy link
Member

wjwwood commented Feb 3, 2014

Closing, the catkinized version is out in groovy and hydro. Please open a new ticket if this is still an open issue.

@wjwwood wjwwood closed this as completed Feb 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants