Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport xacro substitution args fix to fuerte? #5

Closed
jbohren opened this issue Mar 28, 2013 · 8 comments
Closed

Backport xacro substitution args fix to fuerte? #5

jbohren opened this issue Mar 28, 2013 · 8 comments

Comments

@jbohren
Copy link
Member

jbohren commented Mar 28, 2013

#4 fixes broken usage of substitution_args, this is also trivially fixed in the fuerte version, if I submit a PR, can that get released into fuerte?

@ablasdel
Copy link
Contributor

At the moment xacro doesn't build off of github due to a problem with the catkinization and related debacle.
Once #2 is reliably fixed and we move to building off of github we can look into backports.

@jbohren
Copy link
Member Author

jbohren commented May 27, 2013

What's the status of this?

@ablasdel
Copy link
Contributor

@jonbinney Is that fix you were discussing before I left in/working now? If so what are your thoughts on a backport? crazy or only half crazy?

@jonbinney
Copy link

The hydro-devel branch has the workaround for #2 and has been released into hydro. The groovy devel branch also has the fix, but has not been released. Both have the substitution args fix.

I don't think this really matters for this specific issue though. Backporting the substitution args fix to fuerte would involve releasing from github, but not catkinizing.

@jonbinney
Copy link

@jbohren - I created a (currently empty) fuerte-devel branch in this repo. If you merge the substitution args code into the old xacro code and pull request it to fuerte-devel, i'll do the release.

@jonbinney
Copy link

I went ahead and backported the fix into the fuerte-devel branch of this repo. @jbohren @ablasdel can you confirm that this looks OK and works reasonably on fuerte for you?

@wjwwood
Copy link
Member

wjwwood commented Feb 3, 2014

I'm going to close this as stale, since we are not building fuerte debs anymore.

@wjwwood wjwwood closed this as completed Feb 3, 2014
@jbohren
Copy link
Member Author

jbohren commented Feb 3, 2014

Sounds reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants