Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable testing as all tests are commented out anyway #18

Merged
merged 1 commit into from Jun 28, 2018

Conversation

mikaelarguedas
Copy link
Member

@nuclearsandwich FYI this should fix the currently failing jobs

@mikaelarguedas mikaelarguedas added the in progress Actively being worked on (Kanban column) label Jun 28, 2018
Copy link
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is the "right" way to fix this but I'm happy to revisit post-release.

@mikaelarguedas
Copy link
Member Author

This was how it was in ardent, I must have messed up my rebase and reenabled this but as the tests are disabled

# # Override Catkin's GTest configuration to use GMock.
# set(GTEST_FOUND TRUE)
# set(GTEST_INCLUDE_DIRS ${GMOCK_INCLUDE_DIRS})
# set(GTEST_LIBRARIES ${GMOCK_LIBRARIES})
# file(GLOB_RECURSE ALL_SRCS "*.cc" "*.h")
# file(GLOB_RECURSE ALL_TESTS "*_test.cc")
# file(GLOB_RECURSE ALL_EXECUTABLES "*_main.cc")
# list(REMOVE_ITEM ALL_SRCS ${ALL_TESTS})
# list(REMOVE_ITEM ALL_SRCS ${ALL_EXECUTABLES})
there is no point in enabling testing.

When we actually upgrade to the new cartographer (1.0.0) the problem should go away but that'll be for another day

@mikaelarguedas mikaelarguedas merged commit fabe3c5 into ros2 Jun 28, 2018
@mikaelarguedas mikaelarguedas deleted the ignore_tests branch June 28, 2018 20:29
@mikaelarguedas mikaelarguedas removed the in progress Actively being worked on (Kanban column) label Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants