Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CL arguments for building in a temporary directory #375

Closed
wants to merge 2 commits into from

Conversation

brawner
Copy link
Contributor

@brawner brawner commented Jan 27, 2020

This PR adds CL arguments for building inside a temporary directory. When building inside a docker container, CMake's compiler checker runs various debug builds that fail if built inside a mounted directory. The gist of the issue is that the debug symbol files (.PDB) are served by a mspdbsrv.dll, and this has troubles when trying to access files in the mounted directory from the docker container.

Overriding --build-args/test-args when launching run_ros2_batch.py is insufficient because they are not passed to colcon test-result.

This depends on #370, and is depended on by WIP PR #361.

New commit: cd417a5

@brawner brawner requested a review from cottsay January 27, 2020 22:55
Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brawner
Copy link
Contributor Author

brawner commented Jan 27, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@dirk-thomas
Copy link
Member

When building inside a docker container, CMake's compiler checker runs various debug builds that fail if built inside a mounted directory. The gist of the issue is that the debug symbol files (.PDB) are served by a mspdbsrv.dll, and this has troubles when trying to access files in the mounted directory from the docker container.

Can you point to any references for this problem?

On Jenkins we explicitly exclude the workspace from Defender to avoid concurrent access. I am not sure if that is / should be the case here.

@brawner
Copy link
Contributor Author

brawner commented Jan 27, 2020

This is where I have documented the issue, #365 (comment)

Some other references:
docker/for-win#829 (comment)
https://stackoverflow.com/questions/56877220/how-do-i-set-compile-options-for-cmake-msvc-build-in-docker

One of the references mentions adding --isolation=process, which I think I tried, but I forgot the result of that test.

@brawner
Copy link
Contributor Author

brawner commented Feb 11, 2020

This issue was resolved by switching to 1909 and using docker run --isolation=process

@brawner brawner closed this Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants