Pin virtualenv 16.7.9 to fix Python bin installation. #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virtualenv>=20 and venv both set sys.base_prefix to a value outside the virtual environment whereas virtualenv 16.7.9 does not. This triggers virtualenv detection in setuptools/distutils[1] which causes them to ignore our configured install-scripts options. Since this issue is causing test failures and issues with our distributed binary archives, I think it's worth pinning a version of virtualenv that meets our needs while we explore alternatives. [1]: https://github.com/pypa/setuptools/blob/a5dec2f14e3414e4ee5dd146bff9c289d573de9a/setuptools/dist.py#L573-L579 Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
|
Edit: Re-triggered jobs with fixed Python syntax Shameless edit: the package is test_launch_ros not test_ros_launch.
|
Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
I know we've been chatting offline, but for the record this is grudging because the solution is a pin to an old version not because there's anything unsound with the PR itself? |
Yes, sorry, nothing unsound about the PR. I'm mainly just grumpy because the behavior changed so substantially in a near-silent update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
virtualenv>=20 and venv both set
sys.base_prefixto a value outside the virtual environment whereas virtualenv 16.7.9 does not.This triggers virtualenv detection in setuptools/distutils1 which causes them to ignore our configured install-scripts options.
Since this issue is causing test failures and issues with our distributed binary archives (ros2/build_farmer#266), I think it's worth pinning a version of virtualenv that meets our needs while we explore alternatives.
This PR affects a revert of #385 but not because venv itself was unsuitable. We see the same issue using current versions of virtualenv which was totally rewritten for the 20.x series.