Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use venv module for virtualenv creation. #385

Merged
merged 4 commits into from
Feb 13, 2020
Merged

Use venv module for virtualenv creation. #385

merged 4 commits into from
Feb 13, 2020

Conversation

nuclearsandwich
Copy link
Member

Alternative to #384.

The venv module was new in Python 3.3 and contains provides standard
library support for virtualenv creation.

Recent changes in virtualenv 20.0 have made it desireable to consider a
stable virtual environment creation module.

The venv module was new in Python 3.3 and contains provides standard
library support for virtualenv creation.

Recent changes in virtualenv 20.0 have made it desireable to consider a
stable virtual environment creation module.
@nuclearsandwich nuclearsandwich self-assigned this Feb 13, 2020
@nuclearsandwich
Copy link
Member Author

nuclearsandwich commented Feb 13, 2020

Edit: Updated builds after 4c0ab4b, 4a50340

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status <- java connection failure on windshield. The build actually succeeded.
09:23:00 Summary: 930 tests, 0 errors, 0 failures, 1 skipped
09:23:00 
09:23:00 II> colcon test-result returned: '0'
  • Windows-container Build Status

Instead the python venv is invoked with will be used.
This confused me because venv is in python3's standard library but if
the python3-venv package is not installed the following error occurs on
Ubuntu Bionic.

    The virtual environment was not created successfully because ensurepip is not
    available.  On Debian/Ubuntu systems, you need to install the python3-venv
    package using the following command.
        apt-get install python3-venv
    You may need to use sudo with that command.  After installing the python3-venv
    package, recreate your virtual environment.
@nuclearsandwich
Copy link
Member Author

Interpreting the approval as a preference for this PR over #384.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants