Create a version of the clang+libcxx job intended for manual run #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
emersonknapp
force-pushed
the
emersonknapp/manual-clang-libcxx-job
branch
from
f031ddd
to
a4dfde6
Compare
emersonknapp
changed the title
clalancette
requested changes
Apr 7, 2021
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
clalancette
approved these changes
Apr 7, 2021
There was a problem hiding this comment.
Looks good to me. To test this out, I'm going to run a "dry" deploy of this change to CI. Assuming that looks like I expect, I'm going to merge and deploy this for real. Since there isn't really a good way to test the rest of the changes before all of that (without running the nightly job, which I'm reluctant to do), I'll then immediately run a ci_linux_clang_libcxx job.
|
Dry deployment looked good to me, merging. Thanks for the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is only
nightly_linux_clang_libcxx, which doesn't really feel appropriate to use when trying to validate a PR. Add an additionallci_linux_clang_libcxxfor this purpose.