Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a version of the clang+libcxx job intended for manual run #561

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Create a version of the clang+libcxx job intended for manual run #561

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4dfde6
Create a version of the clang+libcxx job intended for manual triggering
Apr 5, 2021
07f4f57
Minor language updates. Remove forcing logging to noop
Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions create_jenkins_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,23 +287,30 @@ def create_job(os_name, job_name, template_file, additional_dict):
'test_args_default': data['test_args_default'] + ' --packages-up-to rcpputils',
})

# configure nightly job for compiling with clang+libcxx on linux
# configure jobs for compiling with clang+libcxx on linux
if os_name == 'linux':
# Set the logging implementation to noop because log4cxx will not link properly when using libcxx.
clang_libcxx_build_args = data['build_args_default'].replace('--cmake-args',
'--cmake-args -DRCL_LOGGING_IMPLEMENTATION=rcl_logging_noop') + \
' --mixin clang-libcxx --packages-skip intra_process_demo'
clang_libcxx_build_args = data['build_args_default'] + ' --mixin clang-libcxx --packages-skip intra_process_demo'
# Only running tests from the lowest-level C package to ensure "working" binaries are generated.
# We do not want to test more than this as we observe issues with the clang libcxx standard library
# we don't plan to tackle for now. The important part of the jobs is to make sure the code compiles
# without emitting thread-safety related warnings.
clang_libcxx_test_args = data['test_args_default'].replace(' --retest-until-pass 2', '') + ' --packages-select rcutils'
# nightly job
create_job(os_name, 'nightly_' + os_name + '_clang_libcxx', 'ci_job.xml.em', {
'cmake_build_type': 'Debug',
'compile_with_clang_default': 'true',
'time_trigger_spec': PERIODIC_JOB_SPEC,
'mailer_recipients': DEFAULT_MAIL_RECIPIENTS + ' ros-contributions@amazon.com',
'build_args_default': clang_libcxx_build_args,
# Only running test from the lowest-level C package to ensure "working" binaries are generated.
# We do not want to test more than this as we observe issues with the clang libcxx standard library
# we don't plan to tackle for now. The important part of this nightly is to make sure the code compiles
# without emitting thread-safety related warnings.
'test_args_default': data['test_args_default'].replace(' --retest-until-pass 2', '') + ' --packages-select rcutils'
'test_args_default': clang_libcxx_test_args,
})
# manually triggered job
create_job(os_name, 'ci_' + os_name + '_clang_libcxx', 'ci_job.xml.em', {
'cmake_build_type': 'None',
'compile_with_clang_default': 'true',
'build_args_default': clang_libcxx_build_args,
'test_args_default': clang_libcxx_test_args,
})

# configure nightly job for testing rmw/rcl based packages with thread sanitizer on linux
Expand Down