Pin the versions of flake8. #675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's some starting CI, just up to rcutils, to make sure things are working as expected. We'll greatly expand what we test from there:
|
clalancette
force-pushed
the
clalancette/pin-flake8
branch
6 times, most recently
from
2d53800
to
c2dd872
Compare
|
OK, here is a similar test on Foxy:
|
clalancette
force-pushed
the
clalancette/pin-flake8
branch
4 times, most recently
from
abfd494
to
af89050
Compare
|
I've had to do some things here that I don't love, but at least I'm getting green results on both Foxy and Rolling. Here's an expanded set of jobs on both Foxy and Rolling to see what happens: Rolling (all packages):
Foxy (all packages):
|
clalancette
force-pushed
the
clalancette/pin-flake8
branch
3 times, most recently
from
dc36388
to
6b3bd96
Compare
clalancette
commented
Aug 1, 2022
clalancette
force-pushed
the
clalancette/pin-flake8
branch
from
6b3bd96
to
5bfeb60
Compare
This also caused us to refactor how we are doing the discovery of pip packages. The new version is actually shorter. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
force-pushed
the
clalancette/pin-flake8
branch
from
5bfeb60
to
b67f789
Compare
|
Here's another set of complete runs, which should hopefully fix the RHEL issue: Rolling (all packages):
Foxy (all packages):
|
This is to support installing colcon from pip. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
This did not end up working well at all, as you can see by all of the yellow and red above. Closing this in favor of #677 , which I think will work better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also caused us to refactor how we are doing the discovery
of pip packages. The new version is actually shorter.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org