Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pydocstyle version constraint #688

Closed

Conversation

iuhilnehc-ynos
Copy link

@iuhilnehc-ynos iuhilnehc-ynos commented Jan 6, 2023

to fix CI warning which related to ros2/rclcpp#2076. such as:

test/test_pep257.py:22: in test_pep257
    rc = main(argv=[])
../../../../install/ament_pep257/lib/python3.10/site-packages/ament_pep257/main.py:125: in main
    report = generate_pep257_report(args.paths, excludes, args.ignore, args.select,
../../../../install/ament_pep257/lib/python3.10/site-packages/ament_pep257/main.py:190: in generate_pep257_report
    for filename, checked_codes, ignore_decorators in files_to_check:
E   ValueError: too many values to unpack (expected 3)

Signed-off-by: Chen Lihui lihui.chen@sony.com

Signed-off-by: Chen Lihui <lihui.chen@sony.com>
@iuhilnehc-ynos
Copy link
Author

iuhilnehc-ynos commented Jan 6, 2023

@clalancette
Copy link
Contributor

So we already fixed this for Rolling in ament/ament_lint#428 . We should just backport that. I'll close this and kick that off now.

@clalancette clalancette closed this Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants