Skip to content

Commit

Permalink
Interface packages should fully <depend> on the interface packages th…
Browse files Browse the repository at this point in the history 
…at they depend on (#173)

Signed-off-by: Michael X. Grey <grey@openrobotics.org>
  • Loading branch information
@mxgrey
mxgrey committed Feb 21, 2022
1 parent fa1d009 commit ea761cc
Show file tree
Hide file tree
Showing 10 changed files with 23 additions and 48 deletions.
6 changes: 2 additions & 4 deletions actionlib_msgs/package.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,10 @@

<buildtool_depend>rosidl_default_generators</buildtool_depend>

<build_depend>builtin_interfaces</build_depend>
<build_depend>std_msgs</build_depend>
<depend>builtin_interfaces</depend>
<depend>std_msgs</depend>

<exec_depend>builtin_interfaces</exec_depend>
<exec_depend>rosidl_default_runtime</exec_depend>
<exec_depend>std_msgs</exec_depend>

<test_depend>ament_lint_common</test_depend>

Expand Down
9 changes: 3 additions & 6 deletions diagnostic_msgs/package.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,11 @@

<buildtool_depend>rosidl_default_generators</buildtool_depend>

<build_depend>builtin_interfaces</build_depend>
<build_depend>geometry_msgs</build_depend>
<build_depend>std_msgs</build_depend>
<depend>builtin_interfaces</depend>
<depend>geometry_msgs</depend>
<depend>std_msgs</depend>

<exec_depend>builtin_interfaces</exec_depend>
<exec_depend>geometry_msgs</exec_depend>
<exec_depend>rosidl_default_runtime</exec_depend>
<exec_depend>std_msgs</exec_depend>

<test_depend>ament_lint_common</test_depend>

Expand Down
3 changes: 1 addition & 2 deletions geometry_msgs/package.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,9 @@

<buildtool_depend>rosidl_default_generators</buildtool_depend>

<build_depend>std_msgs</build_depend>
<depend>std_msgs</depend>

<exec_depend>rosidl_default_runtime</exec_depend>
<exec_depend>std_msgs</exec_depend>

<test_depend>ament_lint_common</test_depend>

Expand Down
9 changes: 3 additions & 6 deletions nav_msgs/package.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,11 @@

<buildtool_depend>rosidl_default_generators</buildtool_depend>

<build_depend>builtin_interfaces</build_depend>
<build_depend>geometry_msgs</build_depend>
<build_depend>std_msgs</build_depend>
<depend>builtin_interfaces</depend>
<depend>geometry_msgs</depend>
<depend>std_msgs</depend>

<exec_depend>builtin_interfaces</exec_depend>
<exec_depend>geometry_msgs</exec_depend>
<exec_depend>rosidl_default_runtime</exec_depend>
<exec_depend>std_msgs</exec_depend>

<test_depend>ament_lint_common</test_depend>

Expand Down
9 changes: 3 additions & 6 deletions sensor_msgs/package.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,11 @@

<buildtool_depend>rosidl_default_generators</buildtool_depend>

<build_depend>builtin_interfaces</build_depend>
<build_depend>geometry_msgs</build_depend>
<build_depend>std_msgs</build_depend>
<depend>builtin_interfaces</depend>
<depend>geometry_msgs</depend>
<depend>std_msgs</depend>

<exec_depend>builtin_interfaces</exec_depend>
<exec_depend>geometry_msgs</exec_depend>
<exec_depend>rosidl_default_runtime</exec_depend>
<exec_depend>std_msgs</exec_depend>

<test_depend>ament_cmake_gtest</test_depend>
<test_depend>ament_lint_auto</test_depend>
Expand Down
4 changes: 1 addition & 3 deletions shape_msgs/package.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,7 @@

<buildtool_depend>rosidl_default_generators</buildtool_depend>

<build_depend>geometry_msgs</build_depend>

<exec_depend>geometry_msgs</exec_depend>
<depend>geometry_msgs</depend>
<exec_depend>rosidl_default_runtime</exec_depend>

<test_depend>ament_lint_common</test_depend>
Expand Down
4 changes: 1 addition & 3 deletions std_msgs/package.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,7 @@

<buildtool_depend>rosidl_default_generators</buildtool_depend>

<build_depend>builtin_interfaces</build_depend>

<exec_depend>builtin_interfaces</exec_depend>
<depend>builtin_interfaces</depend>
<exec_depend>rosidl_default_runtime</exec_depend>

<test_depend>ament_lint_common</test_depend>
Expand Down
6 changes: 2 additions & 4 deletions stereo_msgs/package.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,10 @@

<buildtool_depend>rosidl_default_generators</buildtool_depend>

<build_depend>sensor_msgs</build_depend>
<build_depend>std_msgs</build_depend>
<depend>sensor_msgs</depend>
<depend>std_msgs</depend>

<exec_depend>rosidl_default_runtime</exec_depend>
<exec_depend>sensor_msgs</exec_depend>
<exec_depend>std_msgs</exec_depend>

<test_depend>ament_lint_common</test_depend>

Expand Down
9 changes: 3 additions & 6 deletions trajectory_msgs/package.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,11 @@

<buildtool_depend>rosidl_default_generators</buildtool_depend>

<build_depend>builtin_interfaces</build_depend>
<build_depend>geometry_msgs</build_depend>
<build_depend>std_msgs</build_depend>
<depend>builtin_interfaces</depend>
<depend>geometry_msgs</depend>
<depend>std_msgs</depend>

<exec_depend>builtin_interfaces</exec_depend>
<exec_depend>geometry_msgs</exec_depend>
<exec_depend>rosidl_default_runtime</exec_depend>
<exec_depend>std_msgs</exec_depend>

<test_depend>ament_lint_common</test_depend>

Expand Down
12 changes: 4 additions & 8 deletions visualization_msgs/package.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,12 @@

<buildtool_depend>rosidl_default_generators</buildtool_depend>

<build_depend>builtin_interfaces</build_depend>
<build_depend>geometry_msgs</build_depend>
<build_depend>sensor_msgs</build_depend>
<build_depend>std_msgs</build_depend>
<depend>builtin_interfaces</depend>
<depend>geometry_msgs</depend>
<depend>sensor_msgs</depend>
<depend>std_msgs</depend>

<exec_depend>builtin_interfaces</exec_depend>
<exec_depend>geometry_msgs</exec_depend>
<exec_depend>rosidl_default_runtime</exec_depend>
<exec_depend>std_msgs</exec_depend>
<exec_depend>sensor_msgs</exec_depend>

<test_depend>ament_lint_common</test_depend>

Expand Down

0 comments on commit ea761cc

Please sign in to comment.