-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify vector semantics #115
Conversation
Fixes #92 Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
geometry_msgs/msg/Vector3Stamped.msg
Outdated
@@ -1,4 +1,7 @@ | |||
# This represents a Vector3 with reference coordinate frame and timestamp | |||
|
|||
# Note that this follows vector semantics with it alwasy being at the origin, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Note that this follows vector semantics with it alwasy being at the origin, | |
# Note that this follows vector semantics with it always anchored at the origin, |
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
geometry_msgs/msg/Vector3.msg
Outdated
@@ -1,5 +1,10 @@ | |||
# This represents a vector in free space. | |||
|
|||
# This is semantically different than a point. | |||
# A vector is always anchored at the origin. | |||
# When a trasform is applied to a vector only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# When a trasform is applied to a vector only | |
# When a transform is applied to a vector only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with suggestions applied.
Only nit is that your wrapping is inconsistent between the two files (wrapping at comma in one and at fixed length at other?)
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
Fixes #92