Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Quality levels to level 3 #124

Merged
merged 2 commits into from
Jun 29, 2020
Merged

Update Quality levels to level 3 #124

merged 2 commits into from
Jun 29, 2020

Conversation

brawner
Copy link
Contributor

@brawner brawner commented Jun 26, 2020

Signed-off-by: Stephen Brawner brawner@gmail.com

Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner brawner requested review from ahcorde and Blast545 June 26, 2020 18:30
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • minor question: is there any reason to use the Github view for internal Quality Declarations and the raw.githubusercontent.com for external dependencies ?

Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner brawner requested a review from Blast545 June 29, 2020 18:45
@brawner brawner merged commit c2a65a3 into master Jun 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the brawner/qd-level-3 branch June 29, 2020 19:51
ahcorde pushed a commit that referenced this pull request Oct 27, 2020
* Update Quality levels to level 3

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Address PR Feedback

Signed-off-by: Stephen Brawner <brawner@gmail.com>
ahcorde pushed a commit that referenced this pull request Oct 28, 2020
* Update Quality levels to level 3

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Address PR Feedback

Signed-off-by: Stephen Brawner <brawner@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants