Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prism type to the SolidPrimitive.msg (#166) #167

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Dec 1, 2021

This feature adds a geometry_msgs::msg::Polygon field to the shape_msgs/msg/SolidPrimitive.msg in order to represent PRISM primitive too.

Explained in detail in #166

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx xmfcx force-pushed the add-prism-to-solid-primitive branch from 78ffd64 to c631ba4 Compare December 1, 2021 17:51
Copy link
Member

@gbiggs gbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xmfcx
Copy link
Contributor Author

xmfcx commented Dec 8, 2021

@clalancette is it ok to merge this into master?

@gbiggs gbiggs merged commit 90a4602 into ros2:master Dec 8, 2021
xmfcx added a commit to xmfcx/common_interfaces that referenced this pull request Dec 9, 2021
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
xmfcx added a commit to xmfcx/common_interfaces that referenced this pull request Dec 9, 2021
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants