Add conditional rosidl_generator_cpp in sensor_msgs #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogs9
force-pushed
the
fix/sensor_msgs
branch
from
108bbc4
to
1889d8f
Compare
This was referenced Mar 24, 2022
sloretz
reviewed
Mar 24, 2022
There was a problem hiding this comment.
Opened PR to your branch with feedback: pablogs9#1
Edit: I did it wrong the first time, this PR targets your branch pablogs9#2
pablogs9
force-pushed
the
fix/sensor_msgs
branch
from
1889d8f
to
86518d8
Compare
|
I manually moved the branch. Closing pablogs9#2. Thanks a lot for this fix @sloretz!! This is ready to be merged after ros2/rosidl#672 |
sloretz
approved these changes
Mar 24, 2022
There was a problem hiding this comment.
LGTM with green CI
Requires ros2/rosidl#672
@pablogs9 the single typesupport case requires this bug fix too: ros2/rosidl_typesupport#124
|
CI:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #178 (comment)
CC: @sloretz