Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use regex for matching cv types #202

Merged
merged 3 commits into from
Aug 15, 2022
Merged

use regex for matching cv types #202

merged 3 commits into from
Aug 15, 2022

Conversation

ijnek
Copy link
Contributor

@ijnek ijnek commented Aug 3, 2022 •
edited
Loading

@clalancette Would you mind reviewing because this is a // TODO(clalancette)?

I'm guessing we should keep ABSTRACT_ENCODING_PREFIXES there in case it's being used by others downstream.

gbiggs
gbiggs reviewed Aug 4, 2022
View reviewed changes
Copy link
Member

@gbiggs gbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.

Is there a test that verifies the behaviour is unchanged?

sensor_msgs/include/sensor_msgs/image_encodings.hpp Outdated Show resolved Hide resolved
sensor_msgs/include/sensor_msgs/image_encodings.hpp Outdated Show resolved Hide resolved
ijnek and others added 3 commits August 4, 2022 15:49
@ijnek
use regex for matching cv types
c6c8a5c 
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
@ijnek @gbiggs
Update sensor_msgs/include/sensor_msgs/image_encodings.hpp
3507128 
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
@ijnek @gbiggs
Update sensor_msgs/include/sensor_msgs/image_encodings.hpp
2fff228 
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
@ijnek
Copy link
Contributor Author

ijnek commented Aug 4, 2022 •
edited
Loading

Yes, there were already some tests that verify the behaviour and they pass with these changes: https://github.com/ros2/common_interfaces/blob/rolling/sensor_msgs/test/test_image_encodings.cpp

@gbiggs
Copy link
Member

gbiggs commented Aug 4, 2022

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ijnek
Copy link
Contributor Author

ijnek commented Aug 5, 2022 •
edited
Loading

From the build logs, the problem seems that the packages up-to sensor_msgs aren't being detected in the Build step, any idea why..?

@gbiggs
Copy link
Member

gbiggs commented Aug 14, 2022 •
edited
Loading

I think I misunderstood how --packages-up-to and --packages-above interact, and colcon took the latter first, meaning sensor_msgs didn't have its dependencies available. Trying again with --packages-above-and-dependencies.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@gbiggs gbiggs merged commit c1f53df into ros2:rolling Aug 15, 2022
@ijnek ijnek deleted the ijnek-use-regex branch August 15, 2022 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbiggs gbiggs gbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijnek @gbiggs