Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup mislabeled BSD license #83

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Cleanup mislabeled BSD license #83

merged 1 commit into from
Nov 30, 2021

Conversation

tfoote
Copy link
Contributor

@tfoote tfoote commented Jan 31, 2020

This was propagated due to an invalid license in ament_lint which is proposed to be fixed at: ament/ament_lint#209

jacobperron
jacobperron previously approved these changes Feb 4, 2020

// * Redistributions of source code must retain the above copyright
// notice, this list of conditions and the following disclaimer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As pointed out in https://github.com/ros2/rcpputils/pull/37/files#r373731058, I agree that having blank lines in the middle of the license looks wrong.

@jacobperron jacobperron dismissed their stale review February 4, 2020 02:19

Blank lines look strange

Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several other files can still be patched for aesthetics.

@hidmic
Copy link
Contributor

hidmic commented Dec 2, 2020

@tfoote ping !

Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette clalancette merged commit ba1c052 into master Nov 30, 2021
@clalancette clalancette deleted the bsd3clause_fixup branch November 30, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants