-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mark YUV encodings as deprecated #247
base: rolling
Are you sure you want to change the base?
Conversation
Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de>
cad674b
to
da6770d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking these as deprecated I think makes sense, but we need to have a transition time before they are removed from the implementation as removing them from the implementation will break any current users. The cost of keeping these is moderately low so we should consider a moderately long deprecation cycle. More than just the minimum one release cycle.
da6770d
to
78a764a
Compare
Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de>
78a764a
to
e6c33f7
Compare
The CI marks this as "unstable", probably because there are 6 new warnings (https://build.ros2.org/job/Rpr__common_interfaces__ubuntu_noble_amd64/24/gcc/new/) from the "deprecated-declarations" that are introduced by this PR. @tfoote I guess keeping on using the deprecated encodings is not an option anymore? |
You need to explicitly suppress those warnings that are known to the developer for backwards compatibility. Luckily clang will pick up the GCC ones https://clang.llvm.org/docs/UsersManual.html#controlling-diagnostics-via-pragmas |
Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de>
c558c00
to
771ab2f
Compare
I wrapped the code that is still using the deprecated marked encodings inside the #pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
[...]
#pragma GCC diagnostic pop |
@tfoote Can you have a look at this again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to mark these as deprecated. This will be helpful going forward. The change looks good. Sorry for the high latency, I'm on leave at the moment. I will come back to this for merging when I'm back in the office to avoid disruptions when I can't pay close attention unless someone else gets to it sooner.
#214 introduced new encoding names
uyvy
andyuyv
as replacement foryuv422
andyuv422_yuy2
. This PR marks those replaced encodings as deprecated with a hint which encoding to use instead and removes their usage in this repo.