-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add readme.rst #300
add readme.rst #300
Conversation
lifecycle/README.rst
Outdated
* ``rclcpp_lifecycle::node_interfaces::LifecycleNodeInterface::CallbackReturn | ||
on_cleanup(const rclcpp_lifecycle::State & previous_state)`` | ||
* ``rclcpp_lifecycle::node_interfaces::LifecycleNodeInterface::CallbackReturn | ||
on_shutdown(const rclcpp_lifecycle::State & previous_state)`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functions look a bit weird on github's preview, but the bouncy version looks fine https://github.com/ros2/demos/blob/bouncy/lifecycle/README.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be addressed now
90fd38a
to
e6fec40
Compare
e6fec40
to
a6038ad
Compare
lifecycle/README.rst
Outdated
.. code-block:: bash | ||
|
||
[lc_listener] notify callback: Transition from state unconfigured to configuring | ||
[lc_listener] notify callback: Transition from state configuring to inactive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see two more transitions after these before the listener receives data
[INFO] [lc_listener]: notify callback: Transition from state inactive to activating
[INFO] [lc_listener]: notify callback: Transition from state activating to active
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch. That was a copy paste error.
This is referring to ros2/ros2_documentation#47 (comment)
The documentation of the lifecycle (in fact every demo) should be contained within the package and not duplicated in the
ros2_documentation
package.