Corrected publish calls with shared_ptr signature #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanpauno
added
in progress
|
In many cases same comment as here: ros2/rclcpp#709 (comment) |
wjwwood
requested changes
Apr 29, 2019
There was a problem hiding this comment.
I started commenting on each, but I think most, if not all, can be converted to use a reference rather than a pointer (unique or shared).
Can you please look at each case and try to convert to a reference, and failing that convert to a unique_ptr, and failing that leave it as a shared_ptr. I'll have a look at the cases for the latter two results, because I expect them to be limited, and the shared_ptr to be unnecessary in all cases.
|
Actually, should we prefer Thoughts? |
ivanpauno
force-pushed
the
ivanpauno/deprecate-shared-ptr-publish
branch
from
04ff47f
to
ced1a6a
Compare
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
ivanpauno
force-pushed
the
ivanpauno/deprecate-shared-ptr-publish
branch
from
e14b1d8
to
94f88aa
Compare
sloretz
approved these changes
May 2, 2019
| size_t i = 1; | ||
|
|
||
| // Our main event loop will spin until the user presses CTRL-C to exit. | ||
| while (rclcpp::ok()) { | ||
| // Initialize a shared pointer to an Image message. |
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
mjcarroll
approved these changes
May 3, 2019
wjwwood
approved these changes
May 6, 2019
delete-merged-branch
bot
deleted the
ivanpauno/deprecate-shared-ptr-publish
branch
routiful
pushed a commit
to ROBOTIS-move/demos
that referenced
this pull request
May 7, 2019
* Corrected publish calls with shared_ptr signature Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com> * Corrected with PR comments Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com> * Changed unique_ptr publish calls Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com> * Corrected publish call with unique_ptr in logger_usage_component Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com> * Solve linter problems. Corrected pendulum_control demo. Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com> * Cleaned allocator_tutorial Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com> * Corrected talker_serialized_message.cpp Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com> Signed-off-by: Darby Lim <thlim@robotis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rclcpp#709