Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counter starts from 1, not 2. #562

Merged

Conversation

fujitatomoya
Copy link
Collaborator

  • before
root@tomoyafujita:~/ros2_ws/colcon_ws# ros2 run demo_nodes_cpp talker_loaned_message
[INFO] [1652204561.364158816] [loaned_message_talker]: Publishing: '2.000000'
[INFO] [1652204561.364556243] [rclcpp]: Currently used middleware can't loan messages. Local allocator will be used.
[INFO] [1652204561.364600686] [loaned_message_talker]: Publishing: 'Hello World: 2'
...<snip>
  • after
root@tomoyafujita:~/ros2_ws/colcon_ws# ros2 run demo_nodes_cpp talker_loaned_message
[INFO] [1652205700.592875942] [loaned_message_talker]: Publishing: '1.000000'
[INFO] [1652205700.593295376] [rclcpp]: Currently used middleware can't loan messages. Local allocator will be used.
[INFO] [1652205700.593366279] [loaned_message_talker]: Publishing: 'Hello World: 1'
[INFO] [1652205701.592808672] [loaned_message_talker]: Publishing: '2.000000'
[INFO] [1652205701.592999875] [loaned_message_talker]: Publishing: 'Hello World: 2'
...<snip>

Signed-off-by: Tomoya Fujita Tomoya.Fujita@sony.com

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just weird for me. other demos print the counter from 1.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI.

@fujitatomoya
Copy link
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

@audrow can you merge this?

@clalancette clalancette merged commit b64830e into ros2:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants