Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added README.md for dummy_sensors #573

Merged
merged 4 commits into from
Jan 23, 2023
Merged

Added README.md for dummy_sensors #573

merged 4 commits into from
Jan 23, 2023

Conversation

cardboardcode
Copy link
Contributor

Purpose of Pull Request

This pull request adds a README.md to dummy_sensors as part of efforts to address the issue highlighted in #531.

@cardboardcode
➕ 📖 Added README.md for dummy_sensors ROS2 package. Verified instruct…
4b31819 
…ions.

Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
@audrow audrow self-assigned this Jul 26, 2022
@audrow audrow self-requested a review July 26, 2022 17:01
@cardboardcode cardboardcode marked this pull request as draft August 13, 2022 16:19
@cardboardcode
🔨 Adhered dummy_sensors README.md to approved style of instructions f…
cbc6a95 
…or better cross-platform-compatibility.

Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
@cardboardcode cardboardcode marked this pull request as ready for review January 23, 2023 15:57
clalancette
clalancette requested changes Jan 23, 2023
View reviewed changes
dummy_robot/dummy_sensors/README.md Outdated Show resolved Hide resolved
dummy_robot/dummy_sensors/README.md Outdated Show resolved Hide resolved
dummy_robot/dummy_sensors/README.md Outdated Show resolved Hide resolved
dummy_robot/dummy_sensors/README.md Outdated Show resolved Hide resolved
@cardboardcode
🔨 Updated based on feedback for correct phrasing.
a29c354 
Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
clalancette
clalancette requested changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, a couple more changes that I missed last time. With that done, this looks good to me. Thanks for iterating.

dummy_robot/dummy_sensors/README.md Outdated Show resolved Hide resolved
dummy_robot/dummy_sensors/README.md Outdated Show resolved Hide resolved
dummy_robot/dummy_sensors/README.md Outdated Show resolved Hide resolved
@cardboardcode
🔨 Updated based on feedback to adhere to language-agnostic way to ref…
2e93798 
…er to messages.

Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
clalancette
clalancette approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for the iteration here. Despite the fact that we haven't merged in the related dummy_robot_bringup PR yet, I'm going to merge this in as this is a strict improvement over what was there.

@clalancette clalancette merged commit 404ccd7 into ros2:rolling Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

@mjeronimo mjeronimo Awaiting requested review from mjeronimo mjeronimo is a code owner

Assignees

@audrow audrow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cardboardcode @clalancette @audrow