Allow users to configure the executor for executables in demo_nodes_cpp
#666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yadunund
requested review from
adityapande-1995,
audrow and
mjeronimo
as code owners
Yadunund
requested review from
clalancette
and removed request for
mjeronimo,
audrow and
adityapande-1995
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Yadunund
force-pushed
the
yadu/configure_executor_for_demos
branch
from
9f24288
to
ca3cb76
Compare
mjcarroll
reviewed
Feb 8, 2024
|
BTW 🤘 |
mjcarroll
reviewed
Feb 8, 2024
😈 |
fujitatomoya
approved these changes
Feb 9, 2024
Co-authored-by: Michael Carroll <michael@openrobotics.org> Signed-off-by: Yadu <yadunund@gmail.com> Signed-off-by: Yadunund <yadunund@openrobotics.org>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Yadu <yadunund@gmail.com> Signed-off-by: Yadunund <yadunund@openrobotics.org>
Yadunund
force-pushed
the
yadu/configure_executor_for_demos
branch
from
dc15eb1
to
a801a06
Compare
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
|
CI:
|
mjcarroll
approved these changes
Feb 9, 2024
delete-merged-branch
bot
deleted the
yadu/configure_executor_for_demos
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
cmakebuild flag to allow users to set the type of executor used in executables run in separate processes.Happy to change the name of the flag to something more appropriate if preferred. Also happy to extend this logic to other cpp packages in this repo.