Remove 'node' namespace from rclcpp::Node #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhood
changed the title
wjwwood
approved these changes
Nov 28, 2017
| @@ -24,7 +24,7 @@ class OneOffTimerNode : public rclcpp::Node | |||
| { | |||
| public: | |||
| OneOffTimerNode() | |||
| : rclcpp::Node("one_off_timer"), count(0) | |||
| : Node("one_off_timer"), count(0) | |||
There was a problem hiding this comment.
This is fine (correct) as a shortcut, but the existing code is also fine and a bit more explicit. I don't think you need to change this for this pr, but I wouldn't necessarily say we need to go out and do a similar change everywhere. Both are correct, and I think it's fine to leave it up to the author to decide which to use in the situation.
There was a problem hiding this comment.
OK, no worries, I'll go easy on these ones 😄 thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off #196 (comment):
The style I chose is to match
demos/intra_process_demo/src/cyclic_pipeline/cyclic_pipeline.cpp
Line 30 in 5ba0e66