Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message lost demo status event demo #453

Merged
merged 9 commits into from
Jun 24, 2020

Conversation

ivanpauno
Copy link
Member

@ivanpauno ivanpauno commented Jun 19, 2020

Related to ros2/rmw#226.

TODO:

  • (another PR) Similar demo using rclpy

@ivanpauno ivanpauno added enhancement New feature or request in review Waiting for review (Kanban column) labels Jun 19, 2020
@ivanpauno ivanpauno self-assigned this Jun 19, 2020
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno force-pushed the ivanpauno/add-message-lost-demo branch from 426df5e to d817614 Compare June 23, 2020 22:08
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One spelling correction. Otherwise, LGTM

quality_of_service_demo/README.md Outdated Show resolved Hide resolved
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

Co-authored-by: Jacob Perron <jacob@openrobotics.org>
@ivanpauno
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno merged commit 962bcf9 into master Jun 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/add-message-lost-demo branch June 24, 2020 20:51
@ivanpauno
Copy link
Member Author

Thanks for the review @jacobperron, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in review Waiting for review (Kanban column)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants