Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the set_parameters_callback example program. #608

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Fix the set_parameters_callback example program. #608

merged 1 commit into from
Mar 27, 2023

Commits on Mar 27, 2023

  1. Fix the set_parameters_callback example program. 

    In particular, the 'on_set_parameter_callback' callback
was checking for undeclared parameters, but that could
not have been a problem since 'allow_undeclared_parameters'
is set to false by default.

Instead, change the logic in that callback to arbitrarily
reject parameters > 5.0 (for param1) or < -5.0 (for param2).
That is a much better demonstration of what this node should do.

Also add in a print during the constructor, telling the user what
to expect.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    0ec0f0e View commit details
    Browse the repository at this point in the history