[intra_process_demo] executable name in README.md fix-up #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trushant Adeshara <150821956+Trushant-Adeshara-UM@users.noreply.github.com>
trushant05
requested review from
adityapande-1995,
audrow and
mjeronimo
as code owners
|
@Trushant-Adeshara-UM
i do not see them. probably caching in your local repo? |
|
@fujitatomoya quick question, it is the executable name that needs to be changed in the README.md. So, I just modified that line in the file and committed. Is there something else which I am missing? |
Signed-off-by: Trushant Adeshara <150821956+Trushant-Adeshara-UM@users.noreply.github.com>
fujitatomoya
approved these changes
May 16, 2024
|
@ahcorde i will leave this to you for your comment. |
ahcorde
approved these changes
May 16, 2024
ahcorde
approved these changes
May 16, 2024
|
This is just documentation, merging! |
|
https://github.com/Mergifyio backport jazzy iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 16, 2024
Signed-off-by: Trushant Adeshara <150821956+Trushant-Adeshara-UM@users.noreply.github.com> (cherry picked from commit 4a18995)
mergify bot
pushed a commit
that referenced
this pull request
May 16, 2024
Signed-off-by: Trushant Adeshara <150821956+Trushant-Adeshara-UM@users.noreply.github.com> (cherry picked from commit 4a18995)
This was referenced May 16, 2024
ahcorde
pushed a commit
that referenced
this pull request
May 16, 2024
ahcorde
pushed a commit
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would like to add that the node name needs to be updated to watermark_node (instead of watermarked_node), Line 75 in the README.md. Node name here.