Skip to content
This repository has been archived by the owner on Sep 8, 2023. It is now read-only.

Add continuous integration workflow #38

Merged
merged 7 commits into from
Jun 29, 2020
Merged

Add continuous integration workflow #38

merged 7 commits into from
Jun 29, 2020

Conversation

jacobperron
Copy link
Member

@jacobperron jacobperron commented Jun 25, 2020

Builds on top of #39.

We have some regressions for Dashing and Eloquent (ie. the build_docs.sh script no longer worked with them); #39 is a refactor that enables backwards compatibility, fixing the regressions. This PR adds CI to confirm that things are working and to prevent future regressions.

@jacobperron jacobperron self-assigned this Jun 25, 2020
@jacobperron jacobperron requested a review from ahcorde June 25, 2020 18:28
@jacobperron jacobperron force-pushed the docs_gen_ci branch 3 times, most recently from 91cf2b8 to 1527f45 Compare June 26, 2020 04:31
@ahcorde
Copy link
Contributor

ahcorde commented Jun 26, 2020

Eloquent failure:

make: *** No rule to make target 'src/ros2/rcl/rcl_yaml_param_parser/Doxyfile', needed by 'src/ros2/rcl/rcl_yaml_param_parser/doc_output/html'.  Stop.

PR backporting Doxyfile to Eloquent ros2/rcl#700

@jacobperron
Copy link
Member Author

I've disabled "fail-fast" so jobs aren't canceled if one fails (3d6a5a6)
Also trying the sphinx packages provided by Ubuntu instead of from pip (b9fbefc)

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the path to the executable in the PATH env var make it work

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with all green

@jacobperron
Copy link
Member Author

I expect Foxy CI will fail without ros2/rcl_logging#46

Adds CI for Dashing, Eloquent, and Foxy.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
So that one job failling, doesn't cancel the others.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Member Author

Alright, rebased after #39 was merged. I expect green CI now.

@jacobperron jacobperron merged commit 5a1848e into doc_gen Jun 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the docs_gen_ci branch June 29, 2020 20:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants