Stop installing test resources #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During colcon builds, colcon is using the CMAKE_INSTALL_PREFIX to dictate where the files should be installed to. During Debian and RPM builds, the DESTDIR environment variable is used. The latter approach prefixes all of the install paths, including absolute paths like the destination for the test test resource installation. The end result is that they get installed into the staging directory for the platform package, and typically end up in the package at some unexpected location. For RPM builds, this is a fatal build failure, as ROS packages are not expected to install anything outside of /opt/ros/<foo>. It doesn't appear that installing these resources is even necessary because the working directory of the test means that they're already available to the test that needs them without copying. Signed-off-by: Scott K Logan <logans@cottsay.net>
jacobperron
approved these changes
Apr 8, 2021
There was a problem hiding this comment.
I originally installed the test resources to the build directory for convenience. I.e. we can then run the test directly from the build directory: ./test_parse_domain_bridge_yaml_config
I realize now that we can still run the single test with ctest's -R option: ctest -R test_parse_domain_bridge_yaml_config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During colcon builds, colcon is using the CMAKE_INSTALL_PREFIX to dictate where the files should be installed to. During Debian and RPM builds, the DESTDIR environment variable is used. The latter approach prefixes all of the install paths, including absolute paths like the destination for the test test resource installation.
The end result is that they get installed into the staging directory for the platform package, and typically end up in the package at some unexpected location.
For RPM builds, this is a fatal build failure, as ROS packages are not expected to install anything outside of /opt/ros/.
It doesn't appear that installing these resources is even necessary because the working directory of the test means that they're already available to the test that needs them without copying.
You can see these extra files if you list the contents of the deb: