Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special case for eigen chocolatey package #3

Merged
merged 3 commits into from
Aug 8, 2019
Merged

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Aug 7, 2019

Fix for issue discovered during CI run of ros2/ros2#755

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz added the bug Something isn't working label Aug 7, 2019
@sloretz sloretz self-assigned this Aug 7, 2019
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz
Copy link
Contributor Author

sloretz commented Aug 8, 2019

CI is green: ros2/ros2#755 (comment)

@sloretz sloretz moved this from Proposed to In progress in Dashing Patch Release 3 Aug 8, 2019
Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sloretz sloretz merged commit aee06cb into master Aug 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the eigen3_windows branch August 8, 2019 23:28
@sloretz sloretz moved this from In progress to Needs Release in Dashing Patch Release 3 Aug 8, 2019
@sloretz sloretz moved this from Needs Release to Released in Dashing Patch Release 3 Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants