Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use underscores instead of dashes in setup.cfg #310

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Use underscores instead of dashes in setup.cfg #310

merged 1 commit into from
Apr 21, 2021

Conversation

ivanpauno
Copy link
Member

@ivanpauno ivanpauno commented Apr 19, 2021 •
edited by sloretz
Loading

Fixes https://ci.ros2.org/view/nightly/job/nightly_linux_release/1890/consoleFull#console-section-485 and similar

Starting >>> examples_rclpy_minimal_publisher
03:48:02 /home/jenkins-agent/workspace/nightly_linux_release/venv/lib/python3.8/site-packages/setuptools/dist.py:642: UserWarning: Usage of dash-separated 'script-dir' will not be supported in future versions. Please use the underscore name 'script_dir' instead
03:48:02   warnings.warn(
03:48:02 /home/jenkins-agent/workspace/nightly_linux_release/venv/lib/python3.8/site-packages/setuptools/dist.py:642: UserWarning: Usage of dash-separated 'install-scripts' will not be supported in future versions. Please use the underscore name 'install_scripts' instead
03:48:02   warnings.warn(
03:48:03 /home/jenkins-agent/workspace/nightly_linux_release/venv/lib/python3.8/site-packages/setuptools/dist.py:642: UserWarning: Usage of dash-separated 'script-dir' will not be supported in future versions. Please use the underscore name 'script_dir' instead
03:48:03   warnings.warn(
03:48:03 /home/jenkins-agent/workspace/nightly_linux_release/venv/lib/python3.8/site-packages/setuptools/dist.py:642: UserWarning: Usage of dash-separated 'install-scripts' will not be supported in future versions. Please use the underscore name 'install_scripts' instead
03:48:03   warnings.warn(
03:48:03

@ivanpauno
Use underscores instead of dashes in setup.cfg
51fb7d6 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the bug Something isn't working label Apr 19, 2021
@ivanpauno ivanpauno requested a review from sloretz April 19, 2021 15:55
@ivanpauno ivanpauno self-assigned this Apr 19, 2021
clalancette
clalancette approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI.

@ivanpauno
Copy link
Member Author

ivanpauno commented Apr 20, 2021 •
edited
Loading

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno mentioned this pull request Apr 20, 2021
Merged
@ivanpauno
Copy link
Member Author

It seems that there's something wrong in the CI scripts on Windows, and it cannot handle either of:

  • --packages-up-to-regex "examples_rclpy_.*|sensor_msgs_py"
  • --packages-select-regex "examples_rclpy_.*|sensor_msgs_py"

Another way of building/testing the same:

  • Windows Build Status

@clalancette clalancette merged commit 53b0dd4 into master Apr 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/fix-setup-cfg branch April 21, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@sloretz sloretz sloretz approved these changes

Assignees

@ivanpauno ivanpauno

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanpauno @clalancette @sloretz