Reverted WaitForTopics utility usage #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
jacobperron
reviewed
Oct 11, 2021
| rclpy.shutdown() | ||
|
|
||
|
|
||
| class DummyNode(Node): |
There was a problem hiding this comment.
I would call this WaitForTopics.
If you prefer, we can leave the test above unchanged and just copy the entire WaitForTopics from ros2/launch_ros#274 here.
Either way, we should add a comment TODO here to move the implementation back to launch_ros after ros2/rclpy#831 is resolved.
There was a problem hiding this comment.
Moved entire implementation, added a TODO comment
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
|
Thanks @adityapande-1995! FYI the revert is being addressed here: launch_ros#278 Full CI:
|
jacobperron
approved these changes
Oct 12, 2021
delete-merged-branch
bot
deleted the
aditya/remove_wait_for_topic_action
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed usage of the
WaitForTopicsutiity that was reverted in ros2/launch_ros#276Signed-off-by: Aditya Pande aditya050995@gmail.com