Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python nodes SIGINT handling #372

Closed
thomasmoore-torc opened this issue Feb 29, 2024 · 2 comments · Fixed by #379
Closed

Update python nodes SIGINT handling #372

thomasmoore-torc opened this issue Feb 29, 2024 · 2 comments · Fixed by #379
Assignees
Labels
help wanted Extra attention is needed

Comments

@thomasmoore-torc
Copy link

Bug report

rclpy was updated to automatically handle SIGINT as part of this PR which was incorporated into the Humble release: ros2/rclpy#844

The python nodes in the demos repository were subsequently updated via the following PRs, but those changes were never incorporated into the examples repository.

For consistency, and to ensure that an exception is not thrown when SIGINT is passed to the example python nodes, these same changes should be incorporated into this repository.

@fujitatomoya
Copy link
Collaborator

@thomasmoore-torc thanks for creating issue.

ros2/demos#539

i think #330 aligns with?

ros2/demos#555
ros2/demos#581

those seem like missing?

@thomasmoore-torc
Copy link
Author

@fujitatomoya - it looks like #330 only updated the rclpy/executors examples but not any of the other rclpy examples (e.g. rclpy/topics/minimal_publisher/examples_rclpy_minimal_publisher/publisher_local_function.py).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants