Shutdown asynchronously when sigint is received #844
Merged
+1
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
|
This PR will require some changes in other repos (as shown by the CI jobs), but it seems like a reasonable thing to do, it will make signal handling more consistent (see discussion here). FYI @emersonknapp |
|
This looks good to me! |
This was referenced Nov 8, 2021
|
CI:
|
delete-merged-branch
bot
deleted the
ivanpauno/shutdown-asynchronously-when-sigint
branch
ivanpauno
added a commit
that referenced
this pull request
Dec 22, 2021
This reverts commit 77949d2.
87 tasks
stonier
added a commit
to splintered-reality/py_trees_ros_tutorials
that referenced
this pull request
Feb 4, 2023
stonier
added a commit
to splintered-reality/py_trees_ros_tutorials
that referenced
this pull request
Feb 4, 2023
stonier
added a commit
to splintered-reality/py_trees_ros_tutorials
that referenced
this pull request
Feb 7, 2023
stonier
added a commit
to splintered-reality/py_trees_ros_tutorials
that referenced
this pull request
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #830 (comment).