Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that the rmw implementation matches executable #96

Closed
jacquelinekay opened this issue Mar 22, 2016 · 3 comments
Closed

Verify that the rmw implementation matches executable #96

jacquelinekay opened this issue Mar 22, 2016 · 3 comments
Assignees

Comments

@jacquelinekay
Copy link
Contributor

jacquelinekay commented Mar 22, 2016

@dhood will work on making sure the name of the executable actually matches the middleware implementation.

@wjwwood
Copy link
Member

wjwwood commented May 24, 2016

@dhood I just re-reviewed all the associated PR's. I'd say, run one more set of CI on it (just to make sure something weird didn't happen) and if they pass merge them. Thanks for working on it!

@dhood
Copy link
Member

dhood commented May 24, 2016

yep it's already running now thanks!

On Tue, May 24, 2016 at 3:51 PM, William Woodall notifications@github.com
wrote:

@dhood https://github.com/dhood I just re-reviewed all the associated
PR's. I'd say, run one more set of CI on it (just to make sure something
weird didn't happen) and if they pass merge them. Thanks for working on it!


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#96 (comment)

@dhood
Copy link
Member

dhood commented May 25, 2016

http://ci.ros2.org/job/ci_osx/1044/ (no failures)
http://ci.ros2.org/job/ci_windows/1348/ (failures with age >= 1)
http://ci.ros2.org/job/ci_linux/1323/ (no failures)

merging these prs now

@dhood dhood closed this as completed May 25, 2016
@dhood dhood removed the in review Waiting for review (Kanban column) label May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants