-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify rmw implementation of rclcpp examples at runtime #106
Conversation
rmw_identifier << "'" << std::endl; | ||
return 1; | ||
} | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the kind of thing that I didn't want to have in the examples. (I think it detracts from the otherwise simple example code)
I was thinking we could instead put the ability to check this into the rmw
library itself. I never prototyped this, but I'm still interested in doing it.
If we merge this as-is, I'd want a TODO to remind us that there is probably a way to do it which doesn't affect the user code here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhood see: ros2/rcl#51
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks - I'll integrate it
Before our executable did not exit cleanly when they received a |
@dhood "should we have a macro that checks this for all tests which call it?": no, just opt in where we think it is needed. |
8476fa1
to
d31cee6
Compare
d31cee6
to
fb399cb
Compare
fb399cb
to
d254f1b
Compare
d254f1b
to
84b0fbc
Compare
Modifies existing
rclcpp_examples
tests to act as a regression test for fda5938 (in comparison to #105 which adds new tests to explicitly check the linking)Currently just for
talker
- once approved I can extend to the other executablesNote that I had to modify the exit handler used in the tests in order to get them to fail with the non-zero return code from
talker
(when fda5938 is reverted). This does not seem to have any negative side-effects (no regressions in CI). As a result, I am not entirely clear on the reason it wasignore_exit_handler
before, given that it suppresses errors and seems to have been unnecessary. So, please be extra skeptical of this change in this PR.http://ci.ros2.org/job/ci_windows/1265/
http://ci.ros2.org/job/ci_linux/1218/
http://ci.ros2.org/job/ci_osx/983/
Connects to #96