Ensure using correct rmw implementation in tests #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| set_property( | ||
| TEST test_demo_${exe_list_underscore}${target_suffix} | ||
| APPEND PROPERTY | ||
| ENVIRONMENT RCL_ASSERT_RMW_ID_MATCHES=${rmw_implementation}) |
There was a problem hiding this comment.
Does this work? I'd add it to the ament_add_nose_test(... ENV) option.
There was a problem hiding this comment.
yeah it works fine. I chose it because of the append capability.. I figured it would interfere the least with any future code restructuring this way
There was a problem hiding this comment.
what do you think now @wjwwood
dhood
force-pushed
the
test-linking-runtime
branch
from
5ff24a9
to
c445811
Compare
dhood
force-pushed
the
test-linking-runtime
branch
from
c445811
to
21d8a0f
Compare
|
lgtm |
| @@ -1,6 +1,7 @@ | |||
| import os | |||
| from launch import LaunchDescriptor | |||
| from launch.exit_handler import ignore_exit_handler | |||
| from launch.output_handler import ConsoleOutput | |||
There was a problem hiding this comment.
Should be moved one line lower to be in alphabetical order following PEP 8.
Same in the other file.
This was referenced Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have been discussing adding image_tools tests with @wjwwood but in the meantime this is the change for the existing tests.
Connects to ros2/examples#96