Use eigen3_cmake_module #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
sloretz
added
in review
|
CI is green ros2/ros2#755 (comment) |
clalancette
approved these changes
Aug 9, 2019
tf2_eigen/CMakeLists.txt
Outdated
| find_package(Eigen3 REQUIRED) | ||
| message(STATUS "Using Eigen3 include dirs: ${EIGEN3_INCLUDE_DIR}") | ||
| message(STATUS "Using Eigen3 include dirs: ${Eigen3_INCLUDE_DIRS}") |
There was a problem hiding this comment.
I know you didn't add it, but since you are touching it, I think we should just remove this line. While it is informational, you could say the same about literally any dependency that we use find_package on, so I'm not sure why Eigen is special.
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
sloretz
added a commit
that referenced
this pull request
Aug 23, 2019
* Make tf2_sensor_msgs use eigen3_cmake_module Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Make tf2_eigen use eigen3_cmake_module Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Remove unused Eigen3 dependency from tf2_kdl Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Remove STATUS about Eigen Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
sloretz
added a commit
that referenced
this pull request
Aug 31, 2019
* Make tf2_sensor_msgs use eigen3_cmake_module Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Make tf2_eigen use eigen3_cmake_module Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Remove unused Eigen3 dependency from tf2_kdl Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Remove STATUS about Eigen Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires ros2/eigen3_cmake_module#1Requires ros2/eigen3_cmake_module#3This makes tf2 packages use
eigen3_cmake_moduleeigen3_cmake_modulesince it was finding Eigen3 so it's ready when someone finishes porting this package laterEigen3without using it. This should be handled by theorocos_kdlpackage instead.