Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore conversion via message traits #167

Merged
merged 1 commit into from Oct 15, 2019
Merged

Conversation

mjcarroll
Copy link
Member

Restores the ability to convert via message traits and adds tests for KDL roundtrip conversions through ROS messages.

Depends on: ros2/rosidl#412

Addresses: #125

@mjcarroll mjcarroll self-assigned this Sep 13, 2019
@mjcarroll
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Copy link
Member Author

ReCI after rebase:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mjcarroll
Copy link
Member Author

mjcarroll commented Oct 15, 2019

After pinning fastrtps

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mjcarroll mjcarroll merged commit fc654b8 into ros2 Oct 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the convert_with_traits branch October 15, 2019 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants