Print out the name of the signalFailure reason instead of just its enum value #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…um code And add unit test for the string conversion Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp
force-pushed
the
tf-error-message
branch
from
94dc5b0
to
64f6ed2
Compare
|
@tfoote for review please :) The automatic build seems to be using some out of date dependencies unrelated to this change.
|
dabonnie
reviewed
Oct 22, 2019
dabonnie
reviewed
Oct 22, 2019
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
dabonnie
approved these changes
Oct 22, 2019
zmichaels11
approved these changes
Oct 22, 2019
thomas-moulard
approved these changes
Oct 22, 2019
clalancette
approved these changes
Oct 22, 2019
There was a problem hiding this comment.
This looks generally fine to me, but I'll defer to @tfoote for final review.
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
|
@tfoote can we get a review on this please. |
|
@tfoote friendly ping :) |
|
@tfoote any thoughts? |
tfoote
approved these changes
Nov 18, 2019
mjcarroll
approved these changes
Nov 18, 2019
|
@ros-pull-request-builder retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print a slightly more informative error message from signalFailure in the tf2 MessageFilter and add a unit test for the string conversion.
First half of follow-through for #130
Part of fix for #118
Part of https://github.com/ros-security/aws-roadmap/issues/74
Signed-off-by: Emerson Knapp emerson.b.knapp@gmail.com