Provide more available error messaging for nonexistent and invalid frames in canTransform

[emersonknapp]

• Make error messaging available to callers and provide it in more cases such as for frames that don't exist
• Combine warnFrameId with validateFrameId, allow it to configurably choose between throwing exceptions, passing back error messages, and logging error messages
• Update the uses of these functions and remove fully redundant validation calls - ones that were called twice for seemingly no gain, and potentially involved multiple tf tree walks where one would have sufficed

Second half of follow-through for #130
Part of fix for #118
Part of https://github.com/ros-security/aws-roadmap/issues/74

Signed-off-by: Emerson Knapp emerson.b.knapp@gmail.com

[thomas-moulard]

what are you locking here?
It's preferable locking in scopes to make this clear:

{
  std::unique_lock<std::mutex> lock(frame_mutex_);
  // ...
}

[thomas-moulard]

I.e. could you validate w/o locking?

[emersonknapp]

This line is in the original, it's locking reading of the tf frame tree until the end of the function, for validateFrameId and canTransformNoLock. It shows up as a new line here because it was moved a few lines up.

[thomas-moulard]

Is there a risk of validateFrameId to call back canTransform? If we expect a lock to be held before validateFrameId is called, shouldn't it be validateFrameIdNoLock to align with canTransformNoLock?

[emersonknapp]

It's not that validateFrameID has to have a lock held, but that we are pinning the two validation calls to the same version of the tf tree by acquiring the lock. This doesn't seem to be done in all places where two frames are looked up and then have their transforms checked, and the tree walk happens based on a TimePoint, so I don't think it's necessary. My next version only locks for the tree walk itself. Uploading momentarily

[thomas-moulard]

The new version looks better to me.

[emersonknapp]

@tfoote @rotu ping for review

[emersonknapp]

@tfoote @allenh1 I've updated it with the faster string concatenation method and rebased onto the upstream - PTAL