Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for view_frame #192

Merged
merged 12 commits into from
Nov 26, 2019
Merged

Adding support for view_frame #192

merged 12 commits into from
Nov 26, 2019

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Nov 4, 2019

Moving t2f_tools to ROS 2

  • Adding support for ROS 2.0

dirk-thomas
dirk-thomas reviewed Nov 15, 2019
View reviewed changes
tf2_ros/src/tf2_ros/buffer.py Show resolved Hide resolved
tf2_tools/CHANGELOG.rst Outdated Show resolved Hide resolved
tf2_tools/package.xml Outdated Show resolved Hide resolved
tf2_tools/scripts/view_frames.py Outdated Show resolved Hide resolved
tf2_tools/CMakeLists.txt Show resolved Hide resolved
@dirk-thomas dirk-thomas added the enhancement New feature or request label Nov 15, 2019
dirk-thomas
dirk-thomas reviewed Nov 20, 2019
View reviewed changes
tf2_tools/package.xml Outdated Show resolved Hide resolved
dirk-thomas
dirk-thomas reviewed Nov 20, 2019
View reviewed changes
tf2_tools/scripts/view_frames.py Outdated Show resolved Hide resolved
tf2_ros/src/tf2_ros/buffer.py Outdated Show resolved Hide resolved
tf2_tools/scripts/view_frames.py Outdated Show resolved Hide resolved
tf2_tools/scripts/view_frames.py Outdated Show resolved Hide resolved
dirk-thomas
dirk-thomas approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor nitpick.

tf2_ros/src/tf2_ros/buffer.py Outdated Show resolved Hide resolved
@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Nov 21, 2019
@dirk-thomas
Copy link
Member

@ahcorde Ready to be merged? Should this be backported to distros before Foxy?

@ahcorde ahcorde merged commit 3a088b1 into ros2:ros2 Nov 26, 2019
@ahcorde ahcorde mentioned this pull request Nov 26, 2019
Merged
@dirk-thomas
Copy link
Member

The shebang line of the view_frames.py script (https://github.com/ros2/geometry2/pull/192/files#diff-caff1681fadbfe3ebe6e97b4113d7916R1) wasn't updated. Therefore the script is being run with Python 2 and fails with a SyntaxError.

@ahcorde Please update the shebang line to #!/usr/bin/env python3 and also backport that fix.

@ahcorde ahcorde mentioned this pull request Jan 27, 2020
Merged
@ahcorde
Copy link
Contributor Author

ahcorde commented Jan 27, 2020

Fix: #226
Eloquent backport: #227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcorde @dirk-thomas